[WOOMOB-1068] Add initial implementation of Local Catalog Settings #14717

malinajirka · 2025-10-07T16:53:59Z

Description

This PR implements a first version of the Local Catalog settings.

The designs aren't ready yet, so the UI layer can be mostly ignored.
There are still some TBD comments, since the PR size reached the upper limit.

Unit tests - I skipped unit tests for the VM, since the logic is just dummy. I'll add them in the follow up PR.

Question - currently, the full refresh is performed within VM scope. I'm wondering whether we want to keep it like this or if we want the button to schedule an immediate background sync instead. Wdyt?

Testing information

Open POS
Tap on the more icon
Select Settings
Tap on Catalog
Notice the Local Catalog settings

Verify the Catalog section is not visible when the Local Catalog FF is turned off.

The tests that have been performed

The above

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

-woo-poslocal-catalog-implement-sync-section-in-settings # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/util/format/WooPosDateFormatter.kt # WooCommerce/src/main/res/values/strings.xml # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/util/format/WooPosDateFormatterTest.kt

Copilot

Pull Request Overview

This PR implements the initial version of Local Catalog Settings for WooPos, introducing a new settings category that manages local catalog data and synchronization preferences.

Adds a new "Catalog" settings category with status information, cellular data toggle, and manual refresh functionality
Implements feature flag-based visibility to show/hide the Local Catalog settings
Integrates analytics tracking for the new Local Catalog settings section

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
WooCommerce/src/main/res/values/strings.xml	Adds string resources for Local Catalog settings UI elements
WooPosAnalyticsEvent.kt	Adds analytics event for Local Catalog section tapping
WooPosSettingsLocalCatalogViewModel.kt	Implements ViewModel with catalog status loading and sync functionality
WooPosSettingsLocalCatalogState.kt	Defines state data classes for catalog status and UI state
WooPosSettingsLocalCatalogScreen.kt	Creates Compose UI for Local Catalog settings with status, toggle, and refresh sections
WooPosSettingsDetailPaneScreen.kt	Integrates Local Catalog screen into settings navigation
WooPosSettingsCategoriesViewModel.kt	Adds feature flag logic to conditionally show Local Catalog category
WooPosSettingsCategoriesState.kt	Adds LOCAL_CATALOG enum entry with navigation destination
WooPosSettingsViewModel.kt	Adds analytics tracking for Local Catalog category selection
WooPosSettingsState.kt	Defines navigation destination for Local Catalog settings

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...merce/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogViewModel.kt

...commerce/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogScreen.kt

dangermattic · 2025-10-07T16:54:57Z

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	Class `WooPosSettingsLocalCatalogViewModel` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by 🚫 Danger

wpmobilebot · 2025-10-07T17:00:18Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`240cb05`
	Direct Download	`woocommerce-wear-prototype-build-pr14717-240cb05.apk`

wpmobilebot · 2025-10-07T17:17:01Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`240cb05`
	Direct Download	`woocommerce-prototype-build-pr14717-240cb05.apk`

kidinov · 2025-10-08T13:01:19Z

...ocommerce/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogState.kt

@@ -0,0 +1,14 @@
+package com.woocommerce.android.ui.woopos.settings.details.localcatalog
+
+data class WooPosSettingsLocalCatalogState(


I think this state declaration is a bit ambiguous:

Nullable catalogStatus - when it's null, does that mean loading or error - not clear

Overlapping flags - you could have isLoading and isRefreshing both true at the same time, which is can be correct, but I am not sure. When you hit refresh I'd assume we may want to show catalog status "loading" too?

Maybe something like that?

data class WooPosSettingsLocalCatalogState( val catalogStatus: CatalogStatus = CatalogStatus.Loading, val allowCellularDataUpdate: Boolean = false, ) { sealed class CatalogStatus { data class Available( val catalogSize: String, val lastUpdate: String, val lastFullUpdate: String ) : CatalogStatus() object Loading : CatalogStatus() } }

And when it's "loading" maybe to not show "refresh button" at all?

Good callout! Fixed in 541fce3 and be52b50.

kidinov

LGTM!

I'd just suggest thinking about the state declaration, making sure that it cannot be in an ambiguous state, and checking this in compile time. So ideally, to avoid flags and the nullables there.

codecov-commenter · 2025-10-09T06:14:22Z

Codecov Report

❌ Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.36%. Comparing base (4a856cc) to head (240cb05).
⚠️ Report is 81 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ocalcatalog/WooPosSettingsLocalCatalogViewModel.kt	0.00%	43 Missing ⚠️
...ls/localcatalog/WooPosSettingsLocalCatalogState.kt	0.00%	11 Missing ⚠️
...gs/categories/WooPosSettingsCategoriesViewModel.kt	0.00%	9 Missing ⚠️
.../android/ui/woopos/settings/WooPosSettingsState.kt	0.00%	5 Missing ⚠️
...ttings/categories/WooPosSettingsCategoriesState.kt	0.00%	5 Missing ⚠️
...d/ui/woopos/util/analytics/WooPosAnalyticsEvent.kt	0.00%	2 Missing ⚠️
...roid/ui/woopos/settings/WooPosSettingsViewModel.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #14717      +/-   ##
============================================
- Coverage     38.37%   38.36%   -0.01%     
- Complexity     9855     9871      +16     
============================================
  Files          2099     2102       +3     
  Lines        117044   117132      +88     
  Branches      15657    15670      +13     
============================================
+ Hits          44913    44938      +25     
- Misses        67964    68026      +62     
- Partials       4167     4168       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

malinajirka added 14 commits October 7, 2025 09:06

Add local catalog setting navigation

3be1c9c

tracking

5f81536

Add dummy catalog VM

cfa7968

Add initial Local Catalog settings screen

5e6a277

Introduce date formatter

adeec98

Use actual last update dates

7674a69

Run full catalog sync on manual trigger

079ada9

Show local catalog settings only with FF

0e2b6d9

Replace todos with tbd

a88e91b

Fix detekt

72e9b4b

Make WooPosDateFormatter testable

0bee95f

Add tests for WooPosDateFormatter

9c461a5

Fix strings

6be1314

malinajirka added this to the 23.5 milestone Oct 7, 2025

malinajirka requested a review from Copilot October 7, 2025 16:53

malinajirka added the feature: POS label Oct 7, 2025

Copilot AI reviewed Oct 7, 2025

View reviewed changes

malinajirka commented Oct 7, 2025

View reviewed changes

...commerce/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogScreen.kt Show resolved Hide resolved

malinajirka added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Oct 7, 2025

malinajirka marked this pull request as ready for review October 7, 2025 17:03

malinajirka requested a review from samiuelson October 7, 2025 17:04

malinajirka marked this pull request as draft October 7, 2025 17:06

malinajirka marked this pull request as ready for review October 7, 2025 17:07

Base automatically changed from issue/introduce-pos-date-formatter to trunk October 7, 2025 17:19

malinajirka removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Oct 8, 2025

malinajirka removed the request for review from samiuelson October 8, 2025 08:07

malinajirka requested a review from kidinov October 8, 2025 08:07

malinajirka added the unit-tests-exemption label Oct 8, 2025

kidinov self-assigned this Oct 8, 2025

kidinov reviewed Oct 8, 2025

View reviewed changes

kidinov self-requested a review October 8, 2025 13:01

kidinov approved these changes Oct 8, 2025

View reviewed changes

malinajirka added 3 commits October 9, 2025 07:27

Update PosSettingsLocalCatalog state

541fce3

Disable refresh catalog button when loading status

be52b50

Fix detekt

240cb05

malinajirka enabled auto-merge October 9, 2025 05:48

malinajirka merged commit f62764c into trunk Oct 9, 2025
15 checks passed

malinajirka deleted the issue/woomob-1068-woo-poslocal-catalog-implement-sync-section-in-settings branch October 9, 2025 06:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WOOMOB-1068] Add initial implementation of Local Catalog Settings #14717

[WOOMOB-1068] Add initial implementation of Local Catalog Settings #14717

Uh oh!

malinajirka commented Oct 7, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dangermattic commented Oct 7, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Oct 7, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Oct 7, 2025 •

edited

Loading

Uh oh!

kidinov Oct 8, 2025 •

edited

Loading

Uh oh!

malinajirka Oct 9, 2025

Uh oh!

kidinov left a comment •

edited

Loading

Uh oh!

Uh oh!

codecov-commenter commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		@@ -0,0 +1,14 @@
		package com.woocommerce.android.ui.woopos.settings.details.localcatalog

		data class WooPosSettingsLocalCatalogState(

[WOOMOB-1068] Add initial implementation of Local Catalog Settings #14717

[WOOMOB-1068] Add initial implementation of Local Catalog Settings #14717

Uh oh!

Conversation

malinajirka commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing information

The tests that have been performed

Images/gif

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dangermattic commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kidinov Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

malinajirka Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov-commenter commented Oct 9, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

malinajirka commented Oct 7, 2025 •

edited

Loading

dangermattic commented Oct 7, 2025 •

edited

Loading

wpmobilebot commented Oct 7, 2025 •

edited

Loading

wpmobilebot commented Oct 7, 2025 •

edited

Loading

kidinov Oct 8, 2025 •

edited

Loading

kidinov left a comment •

edited

Loading